[asterisk-dev] [Code Review] Lock channels before calling chan->tech->queryoption and setoption

[Terry Wilson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1220/
-----------------------------------------------------------

(Updated 2011-06-16 16:19:21.303065)


Review request for Asterisk Developers and David Vossel.


Changes
-------

Avoid locking two channels at once for David. He has gone to a lot of trouble making locking more sane here. It would be a shame to frack it up.


Summary
-------

The channel needs to be locked before calling these callback functions. Also, sip_setoption needs to lock the pvt and a check p->rtp is non-null before using it.


Diffs (updated)
-----

  /branches/1.8/channels/chan_local.c 324047 
  /branches/1.8/channels/chan_sip.c 324047 
  /branches/1.8/include/asterisk/channel.h 324047 
  /branches/1.8/main/channel.c 324047 

Diff: https://reviewboard.asterisk.org/r/1220/diff


Testing
-------

Some basic SIP and Local channel calls with Set(CHANNEL(musicclass)=something).


Thanks,

Terry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110616/5bcc9074/attachment-0001.htm>