[asterisk-dev] [Code Review] Set MWI on Register and restore lastmsgssent function

[irroot]

> On 2011-06-16 15:26:15, David Vossel wrote:
> > /team/irroot/distrotech-customers-1.8/channels/chan_sip.c, lines 14377-14381
> > <https://reviewboard.asterisk.org/r/1272/diff/1/?file=17003#file17003line14377>
> >
> >     What happens if this peer doesn't have a mailbox?

The count comes from underlying functions in app_voicemail and has a strlen_zero check.


> On 2011-06-16 15:26:15, David Vossel wrote:
> > /team/irroot/distrotech-customers-1.8/channels/chan_sip.c, line 24817
> > <https://reviewboard.asterisk.org/r/1272/diff/1/?file=17003#file17003line24817>
> >
> >     What does lastmsgssent even mean to us?  It doesn't even look like it is ever used.  Unless we find we need to use it for something, I'd say remove it. Its probably worth looking in 1.4 to see if it is used there in order to understand the history of the variable.

Yes it is "historic" and not used in 1.6/1.8 see patch coming up soon. working toward it.


- irroot


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1272/#review3735
-----------------------------------------------------------


On 2011-06-16 14:49:16, irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1272/
> -----------------------------------------------------------
> 
> (Updated 2011-06-16 14:49:16)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> peer->lastmsgssent is never set ...
> 
> send MWI to peer on register reverting to previous behavior 
> 
> 
> Diffs
> -----
> 
>   /team/irroot/distrotech-customers-1.8/channels/chan_sip.c 323469 
> 
> Diff: https://reviewboard.asterisk.org/r/1272/diff
> 
> 
> Testing
> -------
> 
> This works ans has been tested .... the problem with realtime is lastmsgssent is reset to -1 when
> it is reloaded from db.
> 
> perhaps remove lastmsgssent completely ??
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110616/04d99fb9/attachment-0001.htm>