[asterisk-dev] [Code Review] Replace Berkeley DB astdb with SQLite3

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1269/#review3719
-----------------------------------------------------------



/trunk/main/db.c
<https://reviewboard.asterisk.org/r/1269/#comment7459>

    Can the system header be moved above, or is order important here?  We generally include all system headers first, followed by Asterisk headers.
    
    If ordering is important, please add a comment to that effect, noting the specific Asterisk header.



/trunk/main/db.c
<https://reviewboard.asterisk.org/r/1269/#comment7460>

    This statement should have an additional '/' between the wildcard and the argument specifier.



/trunk/main/db.c
<https://reviewboard.asterisk.org/r/1269/#comment7461>

    Because this boolean statement requires a bit of time to digest, I would suggest changing the st variable to 'dont_care' as we do in other code to show that we're not using the results of the system call, just the return value.



/trunk/main/db.c
<https://reviewboard.asterisk.org/r/1269/#comment7463>

    errmsg, if defined, needs to be free'd before returning.



/trunk/main/db.c
<https://reviewboard.asterisk.org/r/1269/#comment7465>

    If your debug level was 10, how much does this spew?



/trunk/main/db.c
<https://reviewboard.asterisk.org/r/1269/#comment7464>

    As this interface is marked experimental, if we're using a system library and not including sqlite3 directly within the source, this constant will need to be verified in the current system library.


- Tilghman


On 2011-06-13 22:56:50, Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1269/
> -----------------------------------------------------------
> 
> (Updated 2011-06-13 22:56:50)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> There have been a couple of bugs reported lately against the Berkeley DB version that Asterisk uses for its internal database. These bugs have been tracked to the actual Berkeley code Asterisk uses, which is very very old and unmaintained. This patch replaces the Berkeley code with SQLite3 while maintaining exactly the same API. If there is no sqlite3 version of the database already and there is a Berkeley DB version, it automatically converts the old database to the new format.
> 
> If this goes in, I would then like to update Olle's patch for Realtime support for astdb as well and get that in.
> 
> 
> Diffs
> -----
> 
>   /configure UNKNOWN 
>   /trunk/configure.ac 323323 
>   /trunk/main/Makefile 323323 
>   /trunk/main/db.c 323323 
>   /trunk/tests/test_db.c 323323 
> 
> Diff: https://reviewboard.asterisk.org/r/1269/diff
> 
> 
> Testing
> -------
> 
> All astdb tests pass and I have tested converting several astdb databases.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110614/53334528/attachment-0001.htm>