[asterisk-dev] [Code Review] Config inheritance doesn't work with ConfBridge() menu definitions

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1267/#review3713
-----------------------------------------------------------

Ship it!


Nice!


trunk/apps/confbridge/conf_config_parser.c
<https://reviewboard.asterisk.org/r/1267/#comment7451>

    put space between cur->dtmf and menu_entry->dtmf



trunk/apps/confbridge/conf_config_parser.c
<https://reviewboard.asterisk.org/r/1267/#comment7452>

    You could put a break here so it will always exit once if finds an entry since there should never be more than one matching in the list.


- David


On 2011-06-13 14:47:02, opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1267/
> -----------------------------------------------------------
> 
> (Updated 2011-06-13 14:47:02)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Current behavior in ConfBridge menu definitions is that first definition takes precedence, even in templated situations.  This change allows inheritance to work as expected so that the most last definition takes precedence. (issue ASTERISK-17986)
> 
> 
> Diffs
> -----
> 
>   trunk/apps/confbridge/conf_config_parser.c 323152 
> 
> Diff: https://reviewboard.asterisk.org/r/1267/diff
> 
> 
> Testing
> -------
> 
> Test case functional as expected in ASTERISK-17986.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110613/a462b852/attachment.htm>