[asterisk-dev] [Code Review] Timout or error on INFO or MESSAGE transaction causes call to be disconnected. (trunk)

[David Vossel]

> On 2011-06-09 13:26:21, David Vossel wrote:
> > /trunk/channels/chan_sip.c, line 20632
> > <https://reviewboard.asterisk.org/r/1258/diff/1/?file=16861#file16861line20632>
> >
> >     don't you want the in_dialog check before do_msg_auth here?
> 
> rmudgett wrote:
>     Not unless I cannot do authentication within a dialog.  The in_dialog check is to prevent requesting destruction of the dialog if authentication failed.  You do not want a failed MESSAGE to kill your call unexpectedly.
>     
>     Part of this change is to add the ability to authenticate the MESSAGE within a dialog to prevent a third party from injecting messages.

I suppose there is nothing preventing someone from trying to authenticate a message during an established dialog.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1258/#review3699
-----------------------------------------------------------


On 2011-06-08 16:13:05, rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1258/
> -----------------------------------------------------------
> 
> (Updated 2011-06-08 16:13:05)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> JIRA ASTERISK-17901
> 
> Receiving a 408 request timeout response to an INFO or MESSAGE request causes the call to be disconnected.
> 
> The INFO method MUST NOT change the state of calls or related sessions (RFC 2976).
> 
> The MESSAGE method should not change the state of calls or related sessions if associated with a dialog. (Implied by RFC 3428 Section 2).
> 
> This is the trunk version of
> https://reviewboard.asterisk.org/r/1257/
> 
> 
> This addresses bug 19341.
>     https://issues.asterisk.org/jira/browse/19341
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 322485 
> 
> Diff: https://reviewboard.asterisk.org/r/1258/diff
> 
> 
> Testing
> -------
> 
> Should work.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110613/bfaf65c4/attachment-0001.htm>