[asterisk-dev] [Code Review] default sip MESSAGE context option.

Russell Bryant reviewboard at asterisk.org
Mon Jun 13 13:52:19 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1265/#review3711
-----------------------------------------------------------

Ship it!


Looks good.  For bonus points, add another test to the testsuite that uses this option.  You could just copy one of the existing ones, like 'message_unauth', and tweak the configs.

- Russell


On 2011-06-13 09:45:28, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1265/
> -----------------------------------------------------------
> 
> (Updated 2011-06-13 09:45:28)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> Option for setting a default context for all out of call messages to be sent to.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 323105 
>   /trunk/channels/sip/include/sip.h 323105 
>   /trunk/configs/sip.conf.sample 323105 
> 
> Diff: https://reviewboard.asterisk.org/r/1265/diff
> 
> 
> Testing
> -------
> 
> it works. 
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110613/9ac2d930/attachment.htm>


More information about the asterisk-dev mailing list