[asterisk-dev] [Code Review] SRV lookup attempted for peers listed by IP address.

[Simon Perreault]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1240/#review3709
-----------------------------------------------------------



/branches/1.8/main/dnsmgr.c
<https://reviewboard.asterisk.org/r/1240/#comment7448>

    I think it should be PARSE_PORT_FORBID instead of 0.


- Simon


On 2011-05-31 18:13:30, rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1240/
> -----------------------------------------------------------
> 
> (Updated 2011-05-31 18:13:30)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The addition of IPv6 support lost a shortcut in ast_dnsmgr_lookup() if an IP address were configured instead of a host name thus a DNS SRV lookup is attempted when not needed.
> 
> 
> This addresses bug 19248.
>     https://issues.asterisk.org/jira/browse/19248
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/main/dnsmgr.c 321518 
> 
> Diff: https://reviewboard.asterisk.org/r/1240/diff
> 
> 
> Testing
> -------
> 
> Configured an IPv4 address and the code did not do a lookup in ast_dnsmgr_lookup().  Also if this does not work then proxy_update() would also be broken since that code is nearly the same.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110613/cea28434/attachment.htm>