[asterisk-dev] [Code Review] MOH for only user not working with ConfBridge

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1263/#review3704
-----------------------------------------------------------



trunk/apps/confbridge/include/confbridge.h
<https://reviewboard.asterisk.org/r/1263/#comment7447>

    This flag shouldn't go here.  I works but isn't consistent with the use of all the other flags in this field (they're all confbridge.conf options)
    
    Just put some sort of variable on the conference_bridge_user struct itself instead of using the conference_bridge_user->u_profile struct.
    
    Everything else looks good.
    


- David


On 2011-06-10 15:24:42, opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1263/
> -----------------------------------------------------------
> 
> (Updated 2011-06-10 15:24:42)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> From ASTERISK-17988, MOH was stopped by the join sound being played to the user.  This patch addresses that by moving the join sound playback to a more appropriate location.
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_confbridge.c 322980 
>   trunk/apps/confbridge/include/confbridge.h 322980 
> 
> Diff: https://reviewboard.asterisk.org/r/1263/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110610/a89618d6/attachment.htm>