[asterisk-dev] [Code Review] Add SLA to chan_skinny

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1239/#review3662
-----------------------------------------------------------


I started looking and just have a couple of tiny things listed so far.  I wanted to go ahead and ask for sample config updates, though.  That would help me understand how this is used.


trunk/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/1239/#comment7360>

    Why is line needed?  Why not just compare against dest?



trunk/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/1239/#comment7361>

    { on next line


- Russell


On 2011-05-31 17:12:48, wedhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1239/
> -----------------------------------------------------------
> 
> (Updated 2011-05-31 17:12:48)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> Adds sublines to skinny lines. Each subline can be attached to an SLA station/trunk combo. Includes the following functionality:
> 
> Callid is persistent for both in/out calls on all skinny devices.
> Can join, hold, resume.
> All sublines appear under a single line button.
> 
> Limitations:
> Limited signaling for outbound calls (seems to be an issue with SLA blocking the signal).
> Only a single trunk for each station defined in sla.conf (however, multiple stations can be combined in skinny.conf).
> 
> Relevant sample configs can be found on mantis.
> 
> Includes patch to app_meetme, which will be excluded and is covered by M19362.
> 
> 
> This addresses bug 19393.
>     https://issues.asterisk.org/jira/browse/19393
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_skinny.c 319583 
>   trunk/apps/app_meetme.c 319583 
> 
> Diff: https://reviewboard.asterisk.org/r/1239/diff
> 
> 
> Testing
> -------
> 
> Tested on skinny 7940 and 7960.
> 
> 
> Thanks,
> 
> wedhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110607/323491d2/attachment.htm>