[asterisk-dev] [Code Review] app_queue per member ringinuse [ignorebusy] / set chan group on answer / change behaviour of neg penalty

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1119/
-----------------------------------------------------------

(Updated 2011-06-07 05:11:11.424283)


Review request for Asterisk Developers.


Changes
-------

some adhoc cleanups adding braces to conditional's that were missing.
and a stupid spelling mistake.

Updated CHANGES / UPGRADE.txt

 * Added general option negative_penalty_invalid default off. when set
   members are seen as invalid/logged out when there penalty is negative.   
   for realtime members when set remove from queue will set penalty to -1.   
 * Added queue option autopausedelay when autopause is enabled it will be
   delayed for this number of seconds since last successful call if there  
   was no prior call the agent will be autopaused immediately.  
 * Added member option ignorebusy this when set and ringinuse is not
   will allow per member control of multiple calls as ringinuse does for
   the Queue.

Queue:
 - Mark QUEUE_MEMBER_PENALTY Deprecated it never worked for realtime members
 - QUEUE_MEMBER is now R/W supporting setting paused, ignorebusy and penalty.


Summary
-------

This patch is a combination of 3 changes id like to submit.

1)allow a per member ringinuse setting called ignorebusy this was a requirement of a customer and and has been most useful
2)when a call is answered set a channel group this can be used to count active calls as well as be used to not send calls to users flaged above in the dialplan
3)when a member penalty is negative see this as a logged off agent this is a behavior change that allows "removing" realtime agents as well as making IMHO more logic sense if the penalty is neg its not valid 

NB: this is a global config option now as not to change behavior.

4)allow a "grace" period for autopause queue option "autopausedelay" [as requested by a customer we support]

Enjoy the fish


This addresses bugs 18794, 18825 and 18826.
    https://issues.asterisk.org/jira/browse/18794
    https://issues.asterisk.org/jira/browse/18825
    https://issues.asterisk.org/jira/browse/18826


Diffs (updated)
-----

  /trunk/configs/queues.conf.sample 322174 
  /trunk/apps/app_queue.c 322174 
  /trunk/CHANGES 322174 
  /trunk/UPGRADE.txt 322174 

Diff: https://reviewboard.asterisk.org/r/1119/diff


Testing
-------


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110607/06672f35/attachment-0001.htm>