[asterisk-dev] [Code Review] 0019287: inverse / incorrect behavior for CLI / console logging of DTMF

[jrose]

> On 2011-06-03 14:28:01, David Vossel wrote:
> > /branches/1.8/main/asterisk.c, line 1097
> > <https://reviewboard.asterisk.org/r/1244/diff/3/?file=16823#file16823line1097>
> >
> >     couldn't you just do.
> >     
> >     = state ? 0 : 1;
> >     
> >     ?

Sure.  Doesn't make a great deal of difference, but if you feel that's more readable I'll make the change.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1244/#review3671
-----------------------------------------------------------


On 2011-06-03 13:59:13, jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1244/
> -----------------------------------------------------------
> 
> (Updated 2011-06-03 13:59:13)
> 
> 
> Review request for Asterisk Developers, Russell Bryant and David Vossel.
> 
> 
> Summary
> -------
> 
> ast_network_puts_mutable writes to a connected console client only if it's level was set to false.  This changes that function to write it only if it is set to true to resolve the reverse behavior from expectations issue.
> 
> This seems like the way to go, but I can't see for the life of me why this mistake would be made if it really was just a mistake.  It's hard to say.
> 
> 
> This addresses bug 19287.
>     https://issues.asterisk.org/view.php?id=19287
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/include/asterisk/logger.h 321530 
>   /branches/1.8/main/asterisk.c 321530 
> 
> Diff: https://reviewboard.asterisk.org/r/1244/diff
> 
> 
> Testing
> -------
> 
> Just tested with a couple of connected clients.  I'll test more tomorrow.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110603/2e382567/attachment.htm>