[asterisk-dev] [Code Review] 0019287: inverse / incorrect behavior for CLI / console logging of DTMF

jrose reviewboard at asterisk.org
Fri Jun 3 13:59:13 CDT 2011

This is an automatically generated e-mail. To reply, visit:

(Updated 2011-06-03 13:59:13.744456)

Review request for Asterisk Developers, Russell Bryant and David Vossel.


This just adds comments to the previous patch.  I think we should go ahead and commit this as is since actually reversing the values in the levels array is going to lead to a big mess to track down and clean up.


ast_network_puts_mutable writes to a connected console client only if it's level was set to false.  This changes that function to write it only if it is set to true to resolve the reverse behavior from expectations issue.

This seems like the way to go, but I can't see for the life of me why this mistake would be made if it really was just a mistake.  It's hard to say.

This addresses bug 19287.

Diffs (updated)

  /branches/1.8/include/asterisk/logger.h 321530 
  /branches/1.8/main/asterisk.c 321530 

Diff: https://reviewboard.asterisk.org/r/1244/diff


Just tested with a couple of connected clients.  I'll test more tomorrow.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110603/9148a179/attachment.htm>

More information about the asterisk-dev mailing list