[asterisk-dev] [Code Review]: congestion cdr logging

[jrose]

> On July 29, 2011, 12:46 a.m., Alec Davis wrote:
> > /trunk/configs/cdr.conf.sample, line 35
> > <https://reviewboard.asterisk.org/r/1331/diff/1/?file=17669#file17669line35>
> >
> >     If the default is no, then this line should be the opposite.

Just reading the commentary on the setting right above it would suggest otherwise:

; Define whether or not to log unanswered calls. Setting this to "yes" will
; report every attempt to ring a phone in dialing attempts, when it was not
; answered. For example, if you try to dial 3 extensions, and this option is "yes",
; you will get 3 CDR's, one for each phone that was rung. Default is "no". Some
; find this information horribly useless. Others find it very valuable. Note, in "yes"
; mode, you will see one CDR, with one of the call targets on one side, and the originating
; channel on the other, and then one CDR for each channel attempted. This may see
; redundant, but cannot be helped.
;
; In brief, this option controls the reporting of unanswered calls which only have an A 
; party. Calls which get offered to an outgoing line, but are unanswered, are still 
; logged, and that is the intended behaviour. (It also results in some B side CDRs being
; output, as they have the B side channel as their source channel, and no destination 
; channel.)
;unanswered = no

You'll observe that the default for unanswered is no and the commented setting is also no.  This is a similar setting, so it makes sense to do it in the same way.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1331/#review3945
-----------------------------------------------------------


On July 28, 2011, 12:42 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1331/
> -----------------------------------------------------------
> 
> (Updated July 28, 2011, 12:42 p.m.)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> This was a new feature requested some time ago by alecdavis.  There was a code review up for it, but after seeing that tests relied on the behavior in its current state, I nixed the patch after committing it.  
> 
> This resolves the issue of failing tests by making it an option.
> 
> What this patch does is, if in cdr.conf congestion=yes is set, calls ending with congestion will be logged to cdr with a disposition of "CONGESTION" instead of "FAILURE"  Pretty small change on the surface, but it needs to be optional since some people rely on cdr files for various odds and ends.
> 
> I'm currently inclined to think this is a decent way to handle the option, but I'm not 100% sure in the case of what I with the function ast_cdr_congestion when the congestion flag is down.
> 
> 
> This addresses bug ASTERISK-14842.
>     https://issues.asterisk.org/jira/browse/ASTERISK-14842
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 330081 
>   /trunk/configs/cdr.conf.sample 330081 
>   /trunk/include/asterisk/cdr.h 330081 
>   /trunk/main/cdr.c 330081 
>   /trunk/main/pbx.c 330081 
> 
> Diff: https://reviewboard.asterisk.org/r/1331/diff
> 
> 
> Testing
> -------
> 
> Ran testsuite to make sure it doesn't mangle existing tests.
> 
> Ran a congested call with congestion=yes in cdr.conf
> Ran a congested call with congestion=no in cdr.conf
> Ran a congested call with nothing in cdr.conf
> Ran a normal call with congestion=yes in cdr.conf
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110729/2b4d0fed/attachment.htm>