[asterisk-dev] [Code Review] Output of queue log not started until logger reloaded.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1333/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

ASTERISK-15863 caused a regression with queue logging.  The output of the
queue log is not started until the logger configuration is reloaded.

* Queue log initialization is completely delayed until the first message
is posted to the queue log system.  Including the initial opening of the
queue log file.

* Fixed rotate_file() ROTATE strategy to give the file just rotated out to
the configured exec function after rotate.  Just like the other strategies.

* Fixed logger reload to always post the queue reload entry instead of
just if there is a queue log file.

* Refactored some code to eliminate some redundancy and to reduce stack
utilization.


This addresses bug ASTERISK-17036.
    https://issues.asterisk.org/jira/browse/ASTERISK-17036


Diffs
-----

  /branches/1.8/main/logger.c 330104 

Diff: https://reviewboard.asterisk.org/r/1333/diff


Testing
-------

* Simple call to queue to see when the queue log file is created.

* Did logger reload to see that the queue log file is still useable.

* Checked special case where the logger is reloaded before the first queue
log message is posted.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110728/fa296e33/attachment.htm>