[asterisk-dev] [Code Review] congestion cdr logging

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1331/
-----------------------------------------------------------

Review request for Asterisk Developers and David Vossel.


Summary
-------

This was a new feature requested some time ago by alecdavis.  There was a code review up for it, but after seeing that tests relied on the behavior in its current state, I nixed the patch after committing it.  

This resolves the issue of failing tests by making it an option.

What this patch does is, if in cdr.conf congestion=yes is set, calls ending with congestion will be logged to cdr with a disposition of "CONGESTION" instead of "FAILURE"  Pretty small change on the surface, but it needs to be optional since some people rely on cdr files for various odds and ends.

I'm currently inclined to think this is a decent way to handle the option, but I'm not 100% sure in the case of what I with the function ast_cdr_congestion when the congestion flag is down.


This addresses bug ASTERISK-14842.
    https://issues.asterisk.org/jira/browse/ASTERISK-14842


Diffs
-----

  /trunk/CHANGES 330081 
  /trunk/configs/cdr.conf.sample 330081 
  /trunk/include/asterisk/cdr.h 330081 
  /trunk/main/cdr.c 330081 
  /trunk/main/pbx.c 330081 

Diff: https://reviewboard.asterisk.org/r/1331/diff


Testing
-------

Ran testsuite to make sure it doesn't mangle existing tests.

Ran a congested call with congestion=yes in cdr.conf
Ran a congested call with congestion=no in cdr.conf
Ran a congested call with nothing in cdr.conf
Ran a normal call with congestion=yes in cdr.conf


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110728/4ee04a3c/attachment.htm>