[asterisk-dev] [Code Review] fix detection of gcc attributes in menuselect

Tzafrir Cohen reviewboard at asterisk.org
Wed Jul 27 16:53:49 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1330/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

The test for weakref and weak_import attributes is bogus (they are type attributes rather than function attributes). It seems gcc versions before 4.6 somehow let this slip through.

This patch renames the test name (to reflect the new meaning). In the process it gets rid of unnecessary functionality and adds new one.

Note that patch includes changes to autoconf. To use, rerun autoconf (or better: autoreconf) after applying.


Diffs
-----

  /trunk/configure.ac 925 
  /trunk/acinclude.m4 925 

Diff: https://reviewboard.asterisk.org/r/1330/diff


Testing
-------

Only tested on Linux. Requires testing on OSX and I suspect it will not work as-is there.


Thanks,

Tzafrir

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110727/338f523e/attachment.htm>


More information about the asterisk-dev mailing list