[asterisk-dev] [Code Review] Set MWI on Register and restore lastmsgssent function
Michiel van Baak
reviewboard at asterisk.org
Mon Jul 25 04:30:32 CDT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1272/#review3923
-----------------------------------------------------------
Ship it!
Looks good to me.
- Michiel
On July 25, 2011, 4:14 a.m., irroot wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1272/
> -----------------------------------------------------------
>
> (Updated July 25, 2011, 4:14 a.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> peer->lastmsgssent is never set ...
>
> send MWI to peer on register reverting to previous behavior
>
>
> Diffs
> -----
>
> /trunk/channels/chan_sip.c 329388
> /trunk/channels/sip/include/sip.h 329388
>
> Diff: https://reviewboard.asterisk.org/r/1272/diff
>
>
> Testing
> -------
>
> This works ans has been tested .... the problem with realtime is lastmsgssent is reset to -1 when
> it is reloaded from db.
>
> perhaps remove lastmsgssent completely ??
>
>
> Thanks,
>
> irroot
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110725/8aacde29/attachment.htm>
More information about the asterisk-dev
mailing list