[asterisk-dev] [Code Review] Deadlocks dealing with dialplan hints during reload.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1313/
-----------------------------------------------------------

(Updated July 21, 2011, 3:02 p.m.)


Review request for Asterisk Developers, Russell Bryant, David Vossel, and irroot.


Changes
-------

Address David Vossel's comments.


Summary
-------

There are two remaining different deadlocks reported dealing with dialplan
hints.

The deadlock in ASTERISK-17666 is caused by invalid locking order in
ast_remove_hint().  The hints container must be locked before the hint
object.

The deadlock in ASTERISK-17760 is caused by a catch-22 situation in
handle_statechange().  The deadlock is caused by not having the conlock
before calling the watcher callbacks.  Unfortunately, having that lock
causes a different deadlock as reported in ASTERISK-16961.

* Fixed ast_remove_hint() locking order.

* Made handle_statechange() no longer call the watcher callbacks holding
any locks that matter.

* Made hint ao2 destructor do the watcher callbacks for extension
deactivation to guarantee that they get called.

* Fixed hint reference leak in ast_add_hint() if the callback container
constructor failed.

* Fixed hint reference leak in complete_core_show_hint() for every hint it
found for CLI tab completion.

* Adjusted locking in ast_merge_contexts_and_delete() for safety.

* Added context_merge_lock to prevent ast_merge_contexts_and_delete() and
handle_statechange() from interfering with each other.

* Fixed ast_change_hint() not taking into account that the extension is
used for the hash key.


This addresses bugs ASTERISK-17666 and ASTERISK-17760.
    https://issues.asterisk.org/jira/browse/ASTERISK-17666
    https://issues.asterisk.org/jira/browse/ASTERISK-17760


Diffs (updated)
-----

  /branches/1.8/main/pbx.c 329256 

Diff: https://reviewboard.asterisk.org/r/1313/diff


Testing
-------

* Did some calls that changed the state of some hints.
* Reloaded the dialplan.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110721/c5cd66a5/attachment.htm>