[asterisk-dev] [Code Review] app_queue Add StateInterface to Output of "queue show" (CLI) and "QueueStatus" (AMI)

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1300/#review3915
-----------------------------------------------------------

Ship it!


Looks good!

- opticron


On June 27, 2011, 6:38 p.m., jamuel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1300/
> -----------------------------------------------------------
> 
> (Updated June 27, 2011, 6:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds the state_interface of the queue member struct to the output of "queue show" (CLI command) and "QueueStatus" (AMI action) when displaying relevant queue member information.  For the AMI event message the variable StateInterface has been added.
> 
> 
> This addresses bug https://issues.asterisk.org/jira/browse/ASTERISK-18071.
>     https://issues.asterisk.org/jira/browse/https://issues.asterisk.org/jira/browse/ASTERISK-18071
> 
> 
> Diffs
> -----
> 
>   http://svn.asterisk.org/svn/asterisk/trunk/apps/app_queue.c 325045 
> 
> Diff: https://reviewboard.asterisk.org/r/1300/diff
> 
> 
> Testing
> -------
> 
> 1. Added a new member via CLI and correctly see state_interface reflected in the related AMI QueueMemberAdded event and the output of CLI "queue show".  
> 
> 2. AMI action QueueStatus shows the StateInterface as an additional value when displaying member information.
> 
> 3. Added new member via AMI Action AddQueue.  Resultant AMI QueueMemberAdded event shows the StateInterface. 
> 
> 
> Thanks,
> 
> jamuel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110721/763fb13a/attachment.htm>