[asterisk-dev] [Code Review] Convert func_srv test to python.

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1324/#review3899
-----------------------------------------------------------


Looks good, only one comment about timing, see below.


/asterisk/trunk/tests/func_srv/run-test
<https://reviewboard.asterisk.org/r/1324/#comment7721>

    blob



/asterisk/trunk/tests/func_srv/run-test
<https://reviewboard.asterisk.org/r/1324/#comment7720>

    Wait(3) may cause some timing issues, but another method we use is to Echo() or some other application to keep the channel open.


- Paul


On July 20, 2011, 11:19 a.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1324/
> -----------------------------------------------------------
> 
> (Updated July 20, 2011, 11:19 a.m.)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Summary
> -------
> 
> Convert func_srv test to python (from asttest/lua).
> 
> This is the first bit of python code I've written, so this review should be fun (and by that, I mean I'm sure I'll get hammered for doing things stupidly - but that's okay).
> 
> I added mmichelson on this specifically, because he wrote the original version.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/func_srv/configs/ast1/extensions.conf 1740 
>   /asterisk/trunk/tests/func_srv/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   /asterisk/trunk/tests/func_srv/run-test 1740 
>   /asterisk/trunk/tests/func_srv/test-config.yaml 1740 
>   /asterisk/trunk/tests/func_srv/test.lua 1740 
> 
> Diff: https://reviewboard.asterisk.org/r/1324/diff
> 
> 
> Testing
> -------
> 
> The test runs, and stuff matches.
> 
> 
> Thanks,
> 
> Jason
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110720/7a057f11/attachment.htm>