[asterisk-dev] [Code Review] inband DTMF cannot be detected and trigger service execute when A and B both use u-law

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1302/#review3893
-----------------------------------------------------------

Ship it!


Yep, this should do it.  Great work!

- David


On July 13, 2011, 4:50 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1302/
> -----------------------------------------------------------
> 
> (Updated July 13, 2011, 4:50 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When deciding whether Asterisk was allowed to bridge the call away from the core, chan_sip did not take into account the usage of features on dialed channels that require monitoring of DTMF on channels utilizing inband DTMF.  This would cause Asterisk to allow the call to be locally or remotely bridged, preventing access to the data required to detect activations of such features.  chan_sip now checks this and disallows bridging away from the core when using inband DTMF and certain dialed features simultaneously.
> 
> 
> This addresses bug ASTERISK-17237.
>     https://issues.asterisk.org/jira/browse/ASTERISK-17237
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 327949 
>   trunk/include/asterisk/rtp_engine.h 327949 
>   trunk/main/rtp_engine.c 327949 
>   trunk/res/res_rtp_asterisk.c 327949 
> 
> Diff: https://reviewboard.asterisk.org/r/1302/diff
> 
> 
> Testing
> -------
> 
> The scenario described in the bug report now works as expected.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110718/f99e107c/attachment.htm>