[asterisk-dev] [Code Review] MeetMe requests a PIN twice in some circumstances

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1305/#review3892
-----------------------------------------------------------

Ship it!


This if statement seriously hurts my head.  After staring at it for longer than I want to admit, it appeared correct.  If there is anything more you can do to make the logic around this statement easier to follow, please do it.


trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/1305/#comment7716>

    !ast_strlen_zero(args.pin) does the same thing as this line.


- David


On July 12, 2011, 3:34 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1305/
> -----------------------------------------------------------
> 
> (Updated July 12, 2011, 3:34 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> If a call to MeetMe includes both the dynamic(D) and always request PIN(P) options, MeetMe will ask for the PIN two times: once for creating the conference and once for entering the conference.  This behavior was introduced in rev 311616 when adding the CONFFLAG_ALWAYSPROMPT option to the logic branch controlling PIN entry for joining a conference.
> 
> 
> This addresses bug AST-601.
>     https://issues.asterisk.org/jira/browse/AST-601
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_meetme.c 327851 
> 
> Diff: https://reviewboard.asterisk.org/r/1305/diff
> 
> 
> Testing
> -------
> 
> Tested with one and two SIP conference users with and without specified conference numbers.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110718/77a7f8a6/attachment.htm>