[asterisk-dev] [Code Review] no argument monitor

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1320/#review3873
-----------------------------------------------------------

Ship it!


Great work!

- David


On July 13, 2011, 3:45 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1320/
> -----------------------------------------------------------
> 
> (Updated July 13, 2011, 3:45 p.m.)
> 
> 
> Review request for Asterisk Developers, Russell Bryant and David Vossel.
> 
> 
> Summary
> -------
> 
> None of the arguments for monitor actually appear to be required, so this patch removes the "monitor requires arguments" with return and kills a segfault that happened with no args.
> 
> The segfault was caused by trying to strchr a null string pointer.  It worked with any argument other than an empty string though because format is the first value, so even with a comma, format gets set to "".
> 
> 
> This addresses bug AST-609.
>     https://issues.asterisk.org/jira/browse/AST-609
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/res/res_monitor.c 328012 
> 
> Diff: https://reviewboard.asterisk.org/r/1320/diff
> 
> 
> Testing
> -------
> 
> Did some Monitor with some calling and made sure it worked.  It's not a super-elaborate fix.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110714/5c9a2ace/attachment-0001.htm>