[asterisk-dev] [Code Review]: Preserve quality of wideband mixmonitor recordings.

[David Vossel]

> On July 13, 2011, 3:35 p.m., jrose wrote:
> > This looks good and not all like it would cause everything MixMonitor to explode.  I was wondering at the time why we used a set in stone sampling rate, and just figured it must be for recording file size or something like that, but if it's just exploding the files back out again afterwards, this seems much better to me.

Thanks for the review! This was locked in a 8khz signed linear because until recently that was all audiohooks were capable of doing.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1314/#review3869
-----------------------------------------------------------


On July 8, 2011, 12:50 p.m., David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1314/
> -----------------------------------------------------------
> 
> (Updated July 8, 2011, 12:50 p.m.)
> 
> 
> Review request for Asterisk Developers and jrose.
> 
> 
> Summary
> -------
> 
> MixMonitor has the ability to record in any file format Asterisk supports, but the quality of wideband audio is not preserved.  This is because regardless of the sample rate the call is being recorded in, the audio is always downsampled to 8khz and then upsampled to whatever wideband format it is being written as.  This patch resolves this by requesting the audio from the audiohook in the signed linear format closest to the sample rate of the format we are writing.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_mixmonitor.c 327105 
> 
> Diff: https://reviewboard.asterisk.org/r/1314/diff
> 
> 
> Testing
> -------
> 
> Made wideband calls, verified the recording's call quality sounds better than 8khz audio.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110713/c1bfd01e/attachment.htm>