[asterisk-dev] [Code Review] sip_srtp test added to external test suite

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1280/
-----------------------------------------------------------

(Updated July 12, 2011, 4:36 p.m.)


Review request for Asterisk Developers, Paul Belanger and jrose.


Changes
-------

Address reviewboard comments.

* Removed unneeded tcpenable and tcpbindaddr in sip.conf files.

* Made authenticate all calls.

* Made ast2 use 127.0.0.2 IP address instead of a different port.

* Made secure_bridge_media test use "channel originate" instead of
"console dial" CLI command for better portability on test machines.


Summary
-------

These tests check the ability to get SRTP connections:
1) sip_srtp test establishes a SIP call with SRTP to see if the call can get connected.
2) noload_res_srtp test checks to see if a normal SIP call can still be done when SRTP is not loaded.
3) noload_res_srtp_attemtp_srtp test checks to see if the call will fail if SRTP is not enabled and an incoming call requests it.
4) secure_bridge_media test checks to see if SRTP can be requested dynamically for an outgoing call.


Diffs (updated)
-----

  /asterisk/trunk/tests/channels/SIP/noload_res_srtp/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/noload_res_srtp/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/noload_res_srtp/configs/ast2/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/noload_res_srtp/configs/ast2/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/noload_res_srtp/configs/modules.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/noload_res_srtp/run-test PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/noload_res_srtp/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/noload_res_srtp_attempt_srtp/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/noload_res_srtp_attempt_srtp/configs/ast1/manager.general.conf.inc PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/noload_res_srtp_attempt_srtp/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/noload_res_srtp_attempt_srtp/configs/ast2/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/noload_res_srtp_attempt_srtp/configs/ast2/modules.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/noload_res_srtp_attempt_srtp/configs/ast2/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/noload_res_srtp_attempt_srtp/run-test PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/noload_res_srtp_attempt_srtp/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/secure_bridge_media/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/secure_bridge_media/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/secure_bridge_media/configs/ast2/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/secure_bridge_media/configs/ast2/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/secure_bridge_media/run-test PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/secure_bridge_media/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_srtp/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_srtp/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_srtp/configs/ast2/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_srtp/configs/ast2/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_srtp/run-test PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_srtp/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/tests.yaml 1740 

Diff: https://reviewboard.asterisk.org/r/1280/diff


Testing
-------

The tests pass and the debug output shows what is expected for each test.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110712/cd6fcfc0/attachment.htm>