[asterisk-dev] [Code Review] Segfault on shutdown when confbridge is active

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1283/#review3854
-----------------------------------------------------------

Ship it!


Great work, this will fix it.  I don't like that there's a dangling pointer out there during shutdown, but in this case it really doesn't matter.  I have a feeling this can be solved using some channel ref counting of some sort, but I have no idea where to point you.

- David


On June 27, 2011, 9:34 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1283/
> -----------------------------------------------------------
> 
> (Updated June 27, 2011, 9:34 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When undergoing a shutdown and channels are kicked out of a bridge, a segfault occurs because ConfBridge tries to play sounds on the bridge after the underlying channels have been blown away due to the shutdown.  This patch prevents ConfBridge from playing any additional sounds if Asterisk is shutting down.
> 
> 
> This addresses bug ASTERISK-18040.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18040
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_confbridge.c 324709 
> 
> Diff: https://reviewboard.asterisk.org/r/1283/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110711/8df127b7/attachment.htm>