[asterisk-dev] [Code Review]: Read on idle timerfd will result in deadlocks

[jrose]

> On July 6, 2011, 10:20 a.m., David Vossel wrote:
> >
> 
> astmiv wrote:
>     David,
>     
>     Change the if line to:
>     
>     +	if ((timer_status.it_value.tv_sec == 0) && (timer_status.it_value.tv_nsec == 0L)) {
>     +		ast_debug(1, "Reading attempt on idle timerfd.\n");
>     +		return;
>     +	}
>     
>     Does the performance degrade then also?
>     This is part of my submitted patch https://issues.asterisk.org/jira/browse/ASTERISK-17867 (res_timinig_timerfd_read_deadlock.patch)
> 
> jrose wrote:
>     No, regretfully.  This has no apparent effect on the issues mentioned below.

Actually, I mean "yes, regretfully" to the question "Does the performance degrade."  For some reason I had a bit of a disconnect between what you actually said and turned it into "Does this fix it"


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1255/#review3813
-----------------------------------------------------------


On June 3, 2011, 4:11 p.m., kobaz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1255/
> -----------------------------------------------------------
> 
> (Updated June 3, 2011, 4:11 p.m.)
> 
> 
> Review request for Asterisk Developers and russelb.
> 
> 
> Summary
> -------
> 
> Fix for issue https://issues.asterisk.org/view.php?id=18028
> And several others.
> 
> 
> Diffs
> -----
> 
>   branches/1.8/res/res_timing_timerfd.c 320171 
> 
> Diff: https://reviewboard.asterisk.org/r/1255/diff
> 
> 
> Testing
> -------
> 
> Make enough calls to trigger a read on an idle timer
> 
> Wait for message:
> Reading attempt on idle timerfd. This would have caused a deadlock.
> 
> Deadlock avoided.
> 
> 
> Thanks,
> 
> kobaz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110707/67591cb3/attachment.htm>