[asterisk-dev] [Code Review] MeetMe requests a PIN twice in some circumstances

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1305/
-----------------------------------------------------------

(Updated July 7, 2011, 9 a.m.)


Review request for Asterisk Developers.


Changes
-------

Take into account the reason this bug was introduced.  The attached patch now ensures that the bug fixed in review 1132 is not reintroduced as well as fixing this bug.


Summary
-------

If a call to MeetMe includes both the dynamic(D) and always request PIN(P) options, MeetMe will ask for the PIN two times: once for creating the conference and once for entering the conference.  This behavior was introduced in rev 311616 when adding the CONFFLAG_ALWAYSPROMPT option to the logic branch controlling PIN entry for joining a conference.


This addresses bug AST-601.
    https://issues.asterisk.org/jira/browse/AST-601


Diffs (updated)
-----

  trunk/apps/app_meetme.c 325090 

Diff: https://reviewboard.asterisk.org/r/1305/diff


Testing
-------

Tested with one and two SIP conference users with and without specified conference numbers.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110707/81aa53fd/attachment.htm>