[asterisk-dev] [Code Review] Workaround for Google Talk protocol change

[Terry Wilson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1312/
-----------------------------------------------------------

Review request for Asterisk Developers and David Vossel.


Summary
-------

Calls from a GMail client now offer both a jingle session and the old-style session. This patch detects this and ignores the jingle session and uses the other session instead.

It looks like they are now trying to use the actual Jingle spec, so we will want to take a look at writing a parser for that once they start using it for both GTalk and Google Voice. There are some differences with the temporary one that chan_jingle uses.

This fix is a little hacky, but that is just how it goes until they actually switch to "Real Jingle" everywhere.


Diffs
-----

  /branches/1.8/channels/chan_gtalk.c 326513 
  /branches/1.8/include/asterisk/jingle.h 326513 

Diff: https://reviewboard.asterisk.org/r/1312/diff


Testing
-------

I made inbound and outbound GTalk and Google Voice calls and they all rang through.


Thanks,

Terry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110707/30a3be52/attachment-0001.htm>