[asterisk-dev] [Code Review]: adds a timeout argument to app_originate

[Tilghman Lesher]

> On July 6, 2011, 8:35 a.m., irroot wrote:
> > /branches/1.8/CHANGES, lines 12-18
> > <https://reviewboard.asterisk.org/r/1310/diff/2/?file=17377#file17377line12>
> >
> >     This should be under applications for 1.8 -> 1.10 :P made the same mistake recently

More correctly, the patch should be against trunk, not against the 1.8 branch.


> On July 6, 2011, 8:35 a.m., irroot wrote:
> > /branches/1.8/apps/app_originate.c, lines 128-131
> > <https://reviewboard.asterisk.org/r/1310/diff/2/?file=17378#file17378line128>
> >
> >     perhaps a else if (...strlen_z...(...timeout)) and throw a warning if someone puts a invalid timeout ie alpha or neg
> >     
> >     rather use a debug or leave out the timeout set to mesasage

Please use sscanf to convert the argument to an integer.  This function can detect errors, whereas atoi() simply returns 0.  Additionally, the timeout should be limited to a positive non-zero value (or 0 switches to the 30 second default).


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1310/#review3809
-----------------------------------------------------------


On July 6, 2011, 8:31 a.m., jacco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1310/
> -----------------------------------------------------------
> 
> (Updated July 6, 2011, 8:31 a.m.)
> 
> 
> Review request for Asterisk Developers and irroot.
> 
> 
> Summary
> -------
> 
> adds a timeout argument to app_originate
> 
> This application originates an outbound call and connects it to a specified
> extension or application.  This application will block until the outgoing
> call fails or gets answered.  At that point, this application will exit with
> the status variable set and dialplan processing will continue.
> This application sets the following channel variable before exiting:
> ${ORIGINATE_STATUS}: This indicates the result of the call origination.
>     FAILED
>     SUCCESS
>     BUSY
>     CONGESTION
>     HANGUP
>     RINGING
>     UNKNOWN: In practice, you should never see this value.  Please report
>     it to the issue tracker if you ever see it.
> 
> [Syntax]
> Originate(tech_data,type,arg1[,arg2[,arg3[,timeout]]])
> 
> [Arguments]
> tech_data
>     Channel technology and data for creating the outbound channel.
>     For example, SIP/1234.
> type
>     This should be 'app' or 'exten', depending on whether the outbound
>     channel should be connected to an application or extension.
> arg1
>     If the type is 'app', then this is the application name.  If the
>     type is 'exten', then this is the context that the channel will be sent
>     to.
> arg2
>     If the type is 'app', then this is the data passed as arguments to
>     the application.  If the type is 'exten', then this is the extension that
>     the channel will be sent to.
> arg3
>     If the type is 'exten', then this is the priority that the channel
>     is sent to.  If the type is 'app', then this parameter is ignored.
> timeout
>     Timeout in seconds. Default is 30 seconds.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/CHANGES 326468 
>   /branches/1.8/apps/app_originate.c 326468 
> 
> Diff: https://reviewboard.asterisk.org/r/1310/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> jacco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110706/aebedc35/attachment-0001.htm>