[asterisk-dev] [Code Review] Simplify menuselect internals

Tilghman Lesher reviewboard at asterisk.org
Wed Jul 6 08:06:56 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1311/
-----------------------------------------------------------

Review request for Asterisk Developers and Kevin Fleming.


Summary
-------

A change to move a module 'use' to a 'depend' when weak linking is not detected was made recently.  Kpfleming suggested an alternative approach, which is contained in this patch.


This addresses bug ASTERISK-18062.
    https://issues.asterisk.org/jira/browse/ASTERISK-18062


Diffs
-----

  trunk/linkedlists.h 905 
  trunk/menuselect.h 905 
  trunk/menuselect.c 905 
  trunk/menuselect_curses.c 905 
  trunk/menuselect_gtk.c 905 
  trunk/menuselect_newt.c 905 

Diff: https://reviewboard.asterisk.org/r/1311/diff


Testing
-------

Verified that modules get moved correctly and external 'use' libraries do not when 'weak' link detection is removed.


Thanks,

Tilghman

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110706/67ea3592/attachment.htm>


More information about the asterisk-dev mailing list