[asterisk-dev] [Code Review]: Fax Gateway Implementation T30<->T38

[irroot]

> On July 1, 2011, 9:53 a.m., Matthew Nicholson wrote:
> > /trunk/res/res_fax.c, line 3036
> > <https://reviewboard.asterisk.org/r/1116/diff/23/?file=17350#file17350line3036>
> >
> >     Make sure timeout is > 0.

Yes indeed must be > 0


> On July 1, 2011, 9:53 a.m., Matthew Nicholson wrote:
> > /trunk/res/res_fax.c, lines 3037-3040
> > <https://reviewboard.asterisk.org/r/1116/diff/23/?file=17350#file17350line3037>
> >
> >     Print an error message indicating that timeout was not set and return -1 to hangup the channel.

As this is a shared application and voice can proceed it should not hang up


> On July 1, 2011, 9:53 a.m., Matthew Nicholson wrote:
> > /trunk/res/res_fax.c, lines 3047-3052
> > <https://reviewboard.asterisk.org/r/1116/diff/23/?file=17350#file17350line3047>
> >
> >     Rewrite this to return from the function in the event of an error.

Rewriten to allow errors to be reported appropriately.


> On July 1, 2011, 9:53 a.m., Matthew Nicholson wrote:
> > /trunk/res/res_fax.c, line 3038
> > <https://reviewboard.asterisk.org/r/1116/diff/23/?file=17350#file17350line3038>
> >
> >     Instead of using a FAXDETECTED channel var the FAXOPT function should be used.  FAXOPT(status) = SUCCESS could be used to indicate that a FAX was detected with FAXOPT(statusstr) set to CNG or T38 to describe the fax type.

sets FAXOPT(status) to SUCCESS | FAILURE | ERROR and statusstr appropriately.


> On July 1, 2011, 9:53 a.m., Matthew Nicholson wrote:
> > /trunk/res/res_fax.c, lines 229-231
> > <https://reviewboard.asterisk.org/r/1116/diff/23/?file=17350#file17350line229>
> >
> >     Should timeout be required or should the user be allowed to wait forever like with waitmusiconhold?

there must be a timeout and a short one as the application is for "shared" fax/voice lines where this will activate the
fax portion and timeout to voice.

Added a additional option "tone" to allow setting tone played as alternative to silence this would typically
be dial or ring.


- irroot


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1116/#review3796
-----------------------------------------------------------


On July 1, 2011, 9:38 a.m., irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1116/
> -----------------------------------------------------------
> 
> (Updated July 1, 2011, 9:38 a.m.)
> 
> 
> Review request for Asterisk Developers, Russell Bryant, Matthew Nicholson, dimas, may213, Leif Madsen, and dafe_von_cetin.
> 
> 
> Summary
> -------
> 
> Hi there the patch that was going around circa 2008 to implement this in 1.4/1.6 app_fax has been moved to trunk [1.10]
> ive made some cleanups and moved it into res_fax res_fax_spandsp this is the framework and not production code
> unfortunately i have no means of testing it at the moment and require help.
> 
> i have cleaned the code up substantially it is related to R459
> 
> hope this is found useful and aids in the goal to get it in 1.10.
> 
> Adds application FaxGateway / FaxDetect
> Adds alternate bridge to Dial with new option.
> 
> 
> This addresses bugs 13405, 19215 and 19251.
>     https://issues.asterisk.org/jira/browse/13405
>     https://issues.asterisk.org/jira/browse/19215
>     https://issues.asterisk.org/jira/browse/19251
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_fax.c 326048 
> 
> Diff: https://reviewboard.asterisk.org/r/1116/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110703/ff044efb/attachment-0001.htm>