[asterisk-dev] [Code Review] UDPTL structure is created on every sip_alloc which isnt necessary

[Simon Perreault]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1085/#review3144
-----------------------------------------------------------



branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1085/#comment6474>

    Suggestion: add an assert checking that p->udptl is indeed null before allocating it.


- Simon


On 2011-01-26 05:18:39, schmidts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1085/
> -----------------------------------------------------------
> 
> (Updated 2011-01-26 05:18:39)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> on every sip_alloc call a udptl structure is allocated if this dialog needs rtp. This could cause an easy dos condition and also needs much more memory than necessary cause this udptl structe is also allocated in handle_request_invite.
> 
> i can only think of a reinvite situation which could lead to a non allocated udptl structure but i dont think this can happen.
> 
> 
> This addresses bug 18121.
>     https://issues.asterisk.org/view.php?id=18121
> 
> 
> Diffs
> -----
> 
>   branches/1.8/channels/chan_sip.c 304138 
> 
> Diff: https://reviewboard.asterisk.org/r/1085/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> schmidts
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110126/79dd6acf/attachment.htm>