[asterisk-dev] [Code Review] [patch] Confbridge list and kick commands

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1084/#review3126
-----------------------------------------------------------



/trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1084/#comment6390>

    This needs an ao2_iterator_destroy() at the end



/trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1084/#comment6391>

    needs ao2_iterator_destroy()



/trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1084/#comment6392>

    I think bridge should be locked around this loop


- Russell


On 2011-01-24 00:35:30, Brett Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1084/
> -----------------------------------------------------------
> 
> (Updated 2011-01-24 00:35:30)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add's two commands to trunk, confbridge kick and list.
> 
> 
> Usage: confbridge list [<name>]
>        Lists all currently active conference bridges.
> Usage: confbridge kick <name> <channel>
>        Kicks a channel out of the conference bridge.
> 
> 
> This addresses bug 14389.
>     https://issues.asterisk.org/view.php?id=14389
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_confbridge.c 303455 
> 
> Diff: https://reviewboard.asterisk.org/r/1084/diff
> 
> 
> Testing
> -------
> 
> Tested some confbridges with a few users, and successfully listed all conferences, the channels in the conference, and was able to kick them out of the conference with these commands.
> 
> 
> Thanks,
> 
> Brett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110124/90d2ce4e/attachment.htm>