[asterisk-dev] [Code Review] New manager Action: QueueSync

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1079/#review3116
-----------------------------------------------------------


Review the documentation for CODING-GUIDELINES, most of my comments involve them.


trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1079/#comment6381>

    Please include doxygen documentation.



trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1079/#comment6373>

    if (...) {
         blah();
    }



trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1079/#comment6374>

    space between while and (



trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1079/#comment6375>

    spacing, and braces.



trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1079/#comment6376>

    spacing



trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1079/#comment6377>

    space



trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1079/#comment6379>

    same



trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1079/#comment6378>

    braces



trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1079/#comment6380>

    Missing { } for if statements.


- Paul


On 2011-01-20 19:03:22, elbriga wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1079/
> -----------------------------------------------------------
> 
> (Updated 2011-01-20 19:03:22)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I've had some problems with the time that took to login agents via AMI, since I had to first make sure they're removed from all queues first, and then I've QueueAdd them to the Queues they belong.
> 
>   With this code in I can send an AMI command like this:
> 
> Action: QueueSync
> Queues: queue1,queue5,queue7
> Interface: SIP/pa01
> Paused: 0
> MemberName: Agent01
> 
>   And that will make sure that Agent01 gets added to the queues listed (queue1,queue5,queue7) AND removed from all the other queues, with just one AMI command.
> 
>   It will silently ignore errors such as "Already There", thus the only possible error that it can cause is an RES_OUTOFMEMORY error.
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_queue.c 303196 
> 
> Diff: https://reviewboard.asterisk.org/r/1079/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> elbriga
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110121/33a02c50/attachment-0001.htm>