[asterisk-dev] [Code Review] [patch] MulticastRTP crashing due to use of uninitialized data

[Simon Perreault]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1076/#review3096
-----------------------------------------------------------


IMHO it would be better style to call ast_sockaddr_setnull() instead.

- Simon


On 2011-01-14 13:28:01, Brett Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1076/
> -----------------------------------------------------------
> 
> (Updated 2011-01-14 13:28:01)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The MulticastRTP channel driver used unitialized data, causing it to copy into memory that was invalid.
> 
> 
> This addresses bug 18290.
>     https://issues.asterisk.org/view.php?id=18290
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_multicast_rtp.c 301840 
> 
> Diff: https://reviewboard.asterisk.org/r/1076/diff
> 
> 
> Testing
> -------
> 
> Replicated the crash locally, and verified using wireshark after the patch was applied that Multicast data was being sent to the IP/port issued in Dial.
> 
> 
> Thanks,
> 
> Brett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110114/83629e0f/attachment-0001.htm>