[asterisk-dev] [Code Review] New Media Architecture phase 1 step 1

[Terry Wilson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1062/#review3088
-----------------------------------------------------------



/trunk/include/asterisk/format.h
<https://reviewboard.asterisk.org/r/1062/#comment6346>

    Any reason it isn't ast_format_copy(dst, src) to be more consistent with how other C copy functions work? It always makes me do a double take anytime I see copy functions go against the order in str/memcpy, etc.



/trunk/include/asterisk/format.h
<https://reviewboard.asterisk.org/r/1062/#comment6342>

    red



/trunk/include/asterisk/format.h
<https://reviewboard.asterisk.org/r/1062/#comment6345>

    This is a general comment for the IAX2 layer in general. Does this really need to be in the general API or can it be in iax-specific code only? Just seems weird having protocol-specific helper functions in the main API.



/trunk/include/asterisk/format.h
<https://reviewboard.asterisk.org/r/1062/#comment6343>

    red



/trunk/include/asterisk/format.h
<https://reviewboard.asterisk.org/r/1062/#comment6347>

    As above with the src/dst order. dst, src is a much more common order. 



/trunk/include/asterisk/format_cap.h
<https://reviewboard.asterisk.org/r/1062/#comment6348>

    and the src, dst thing again. :-p



/trunk/main/format.c
<https://reviewboard.asterisk.org/r/1062/#comment6344>

    This code is repeated many times. Perhaps a helper function find_interface(id) which hides all of the locking to avoid accidentally messing it up somewhere?


- Terry


On 2010-12-20 15:36:29, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1062/
> -----------------------------------------------------------
> 
> (Updated 2010-12-20 15:36:29)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> Here is what I am working on. https://wiki.asterisk.org/wiki/display/AST/Media+Architecture+Proposal
> 
> This is phase 1 step 1 of that proposal.
> 
> Below is everything that is included in this review.
> 
> Step 1
>     * Define new format unique ID system using numbers rather than bits. Allow this definition to remain unused during this step except by the new APIs.
>     * Create Ast Format API + unit tests.
>     * Create Ast Capibility API + unit tests.
>     * Create IAX2 Conversion layer for ast_format and ast_cap objects. Create unit tests and leave this layer inactive until conversion to new APIs takes place.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/format.h PRE-CREATION 
>   /trunk/include/asterisk/format_cap.h PRE-CREATION 
>   /trunk/main/asterisk.c 299246 
>   /trunk/main/format.c PRE-CREATION 
>   /trunk/main/format_cap.c PRE-CREATION 
>   /trunk/tests/test_format_api.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1062/diff
> 
> 
> Testing
> -------
> 
> Unit tests are included.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110112/de83c520/attachment-0001.htm>