[asterisk-dev] [Code Review] updates to safe_asterisk

Paul Belanger reviewboard at asterisk.org
Wed Jan 5 11:07:16 CST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1067/#review3079
-----------------------------------------------------------

Ship it!


- Paul


On 2011-01-03 17:49:48, thedavidfactor wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1067/
> -----------------------------------------------------------
> 
> (Updated 2011-01-03 17:49:48)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I had to make some changes to safe_asterisk. While working on it I thought there were a couple of changes that would be helpful to the community. I assume "Ben" wouldn't want to get a bunch of notifications so I changed the default address to root on the local machine. I also thought defaulting the log location to the asterisk log directory made sense.
> 
> 
> Diffs
> -----
> 
>   /trunk/Makefile 300120 
>   /trunk/contrib/scripts/safe_asterisk 300120 
> 
> Diff: https://reviewboard.asterisk.org/r/1067/diff
> 
> 
> Testing
> -------
> 
> did a make and install with the changes and confirmed that the path was substituted as expected
> 
> 
> Thanks,
> 
> thedavidfactor
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110105/48c0040e/attachment.htm>


More information about the asterisk-dev mailing list