[asterisk-dev] [Code Review] Replace ast_log(LOG_DEBUG, ...) with ast_debug()

Paul Belanger reviewboard at asterisk.org
Tue Jan 4 21:30:30 CST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1071/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

After some recent discussion on -dev mailing list, I decided to write the patch.   Additionally, removed red blobs (whitespaces) while reviewing ast_debug() changes.

The next patch would be to change ast_log(LOG_VERBOSE) / ast_verbose() to use ast_verb().


This addresses bug 18556.
    https://issues.asterisk.org/view.php?id=18556


Diffs
-----

  trunk/addons/chan_ooh323.c 300567 
  trunk/apps/app_fax.c 300567 
  trunk/apps/app_meetme.c 300567 
  trunk/apps/app_rpt.c 300567 
  trunk/apps/app_voicemail.c 300567 
  trunk/cel/cel_radius.c 300567 
  trunk/channels/chan_dahdi.c 300567 
  trunk/channels/chan_gtalk.c 300567 
  trunk/channels/chan_iax2.c 300567 
  trunk/channels/chan_misdn.c 300567 
  trunk/channels/chan_sip.c 300567 
  trunk/channels/chan_skinny.c 300567 
  trunk/channels/sig_pri.c 300567 
  trunk/codecs/codec_ilbc.c 300567 
  trunk/include/asterisk/channel.h 300567 
  trunk/include/asterisk/sched.h 300567 
  trunk/main/app.c 300567 
  trunk/main/audiohook.c 300567 
  trunk/main/channel.c 300567 
  trunk/main/features.c 300567 
  trunk/main/http.c 300567 
  trunk/main/logger.c 300567 
  trunk/main/manager.c 300567 
  trunk/main/pbx.c 300567 
  trunk/main/say.c 300567 
  trunk/main/taskprocessor.c 300567 
  trunk/main/xmldoc.c 300567 
  trunk/pbx/pbx_loopback.c 300567 
  trunk/pbx/pbx_spool.c 300567 
  trunk/res/ais/evt.c 300567 
  trunk/res/res_agi.c 300567 
  trunk/res/res_config_ldap.c 300567 
  trunk/res/res_http_post.c 300567 
  trunk/res/res_jabber.c 300567 
  trunk/res/res_musiconhold.c 300567 
  trunk/res/res_odbc.c 300567 
  trunk/res/res_rtp_asterisk.c 300567 
  trunk/res/res_smdi.c 300567 
  trunk/utils/extconf.c 300567 

Diff: https://reviewboard.asterisk.org/r/1071/diff


Testing
-------

Compiling on local dev box.


Thanks,

Paul

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110105/d660f33d/attachment.htm>


More information about the asterisk-dev mailing list