[asterisk-dev] [svn-commits] lmadsen: branch 1.8 r300082 - /branches/1.8/pbx/pbx_dundi.c

[Russell Bryant]

On Tue, 2011-01-04 at 13:40 -0600, Tilghman Lesher wrote:
> There's no benefit to using stringfields if the value does not change past
> creation.

The opposite, actually.  String fields were not intended to be used at
all for strings that change.  The code was later updated to attempt to
reclaim unused pools, but it shouldn't be relied upon.

In the case of this structure, there are 3 strings that only get set a
single time, which is the exact sort of situation where string fields
should be used.

-- 
Russell Bryant
Digium, Inc.  |  Engineering Manager, Open Source Software
445 Jan Davis Drive NW   -    Huntsville, AL 35806  -  USA
jabber: rbryant at digium.com    -=-    skype: russell-bryant
www.digium.com -=- www.asterisk.org -=- blogs.asterisk.org