[asterisk-dev] [svn-commits] lmadsen: branch 1.8 r300082 - /branches/1.8/pbx/pbx_dundi.c

[Tilghman Lesher]

On Monday 03 January 2011 10:57:48 Russell Bryant wrote:
> On Mon, 2011-01-03 at 15:53 +0100, Olle E.Johansson wrote:
> > 3 jan 2011 kl. 14.14 skrev SVN commits to the Digium repositories:
> > > Author: lmadsen
> > > Date: Mon Jan  3 07:14:25 2011
> > > New Revision: 300082
> > > 
> > > URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=300082
> > > Log:
> > > Increase side of mapping response field.
> > 
> > I am aware that there's no clear policy for 1.8, but it is in fact
> > released. This doesn't seem like a bug fix, unless your own
> > documentation is a reported bug. I don't see a reference to a
> > reviewboard discussion or anything either...
> > 
> > So why was this committed to released code? It seems like a change for
> > 1.10 to me.
> > 
> > As a side note, is there a protocol spec anywhere declaring this
> > field? should that be changed?
> > 
> > Just trying to understand.
> 
> It's not protocol related.  It's configuration related.  In the DUNDi
> mappings configuration, you set up a "tech/data" response field.  This
> increased the buffer size for the data part.  The buffer size was far
> too small to support very realistic configurations if you dynamically
> generate the data using a combination of dialplan functions.  I asked
> him to commit it to 1.8 since it was small enough to cause problems for
> reasonable configurations.

While that's understandable, why wasn't this committed to 1.4, first, as a
bugfix should go into all applicable versions?  That it went into 1.8 aids
suspicion that it wasn't a bugfix at all, but a late feature-add.

-- 
Tilghman