[asterisk-dev] [svn-commits] lmadsen: branch 1.8 r300082 - /branches/1.8/pbx/pbx_dundi.c

[Olle E. Johansson]

3 jan 2011 kl. 14.14 skrev SVN commits to the Digium repositories:

> Author: lmadsen
> Date: Mon Jan  3 07:14:25 2011
> New Revision: 300082
> 
> URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=300082
> Log:
> Increase side of mapping response field.

I am aware that there's no clear policy for 1.8, but it is in fact released. This doesn't seem like a bug fix, unless your own documentation is a reported bug.
I don't see a reference to a reviewboard discussion or anything either...

So why was this committed to released code? It seems like a change for 1.10 to me.

As a side note, is there a protocol spec anywhere declaring this field? should that be changed?

Just trying to understand.

/O
> 
> I've increased the size of the response field in a DUNDi mapping because of
> some documentation I'm writing. Previously it was set to AST_MAX_EXTENSION which
> is only 80 characters, which is far too small when you're using some dialplan
> functions to craft a response. The example I'm using is:
> 
> extensions =>
> RegisteredDevices,0,SIP,dundi:very_awesome_password/${IF($[${DB_EXISTS(phones/${NUMBER}/device)}]?${DB(phones/${NUMBER}/device)}:None)},nopartial
> 
> 
> Modified:
>    branches/1.8/pbx/pbx_dundi.c
> 
> Modified: branches/1.8/pbx/pbx_dundi.c
> URL: http://svnview.digium.com/svn/asterisk/branches/1.8/pbx/pbx_dundi.c?view=diff&rev=300082&r1=300081&r2=300082
> ==============================================================================
> --- branches/1.8/pbx/pbx_dundi.c (original)
> +++ branches/1.8/pbx/pbx_dundi.c Mon Jan  3 07:14:25 2011
> @@ -286,7 +286,7 @@
> 	int options;
> 	int tech;
> 	int dead;
> -	char dest[AST_MAX_EXTENSION];
> +	char dest[512];
> 	AST_LIST_ENTRY(dundi_mapping) list;
> };
> 
> 
> 
> --
> _____________________________________________________________________
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
> 
> svn-commits mailing list
> To UNSUBSCRIBE or update options visit:
>   http://lists.digium.com/mailman/listinfo/svn-commits

---
* Olle E Johansson - oej at edvina.net
* Cell phone +46 70 593 68 51, Office +46 8 96 40 20, Sweden