[asterisk-dev] [Code Review] app_directed_pickup Implement the ability to remove a channel group on bridged channel

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1118/
-----------------------------------------------------------

(Updated 2011-02-21 07:43:13.894838)


Review request for Asterisk Developers.


Changes
-------

Thx for the feedback Russel here is a reworked patch based on your info that uses 
PICKUP_BRIDGE_MACRO
PICKUP_BRIDGE_MACRO_ARGS

we need to wait for the bridge to come up before we run this macro to allow masquerade to complete its magic.

replaced the call to ast_pickup_call with internal function that calls do_pickup to make all cases work.


Summary
-------

as a companion to 0018825 to aid with the move from call-limits to channel group variables. the problem with pickup and queue is that they manage channels outside the dialplan and need "helpers" to deal with channel groups.

in the case of pickup when a call is placed to a extension with say a "<EXTEN>@called" channel group when it is picked up this needs to be cleared to allow further calls when call waiting is disabled.

exten => s,n,GotoIf($[$[${ GROUP_COUNT(${ARG1}@called)} >= 1] | $[${GROUP_COUNT(${ARG1}@caller)} >= 1] | $[${GROUP_COUNT(${ARG1}@pickup)} >= 1] | $[${GROUP_COUNT(${ARG1}@qagent)} >= 1]]?s-BUSY,1)

where
caller is set when a call is placed.
called is set when a call is received
pickup is set when before calling pickup in the dialplan
qagent is set with patch to queue

Hope this is found to be useful and finds a home in trunk. 

not sure what time to put in the "wait for bridge" perhaps there is a better method ?? 


This addresses bug 18830.
    https://issues.asterisk.org/view.php?id=18830


Diffs (updated)
-----

  /trunk/apps/app_directed_pickup.c 308283 

Diff: https://reviewboard.asterisk.org/r/1118/diff


Testing
-------


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110221/37ddef75/attachment.htm>