[asterisk-dev] [Code Review] Force module dependencies to load in the correct order

Tilghman Lesher reviewboard at asterisk.org
Sat Feb 19 05:09:15 CST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1121/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

A post on the mailing list inspired this patch, to force certain dependencies (which are not optional-api-related) to be loaded automatically when a module requiring them is loaded.  Code review is needed, because the module API will be modified within this changeset.


Diffs
-----

  /branches/1.8/apps/app_speech_utils.c 308287 
  /branches/1.8/channels/chan_gtalk.c 308287 
  /branches/1.8/channels/chan_jingle.c 308287 
  /branches/1.8/funcs/func_curl.c 308287 
  /branches/1.8/funcs/func_odbc.c 308287 
  /branches/1.8/include/asterisk/module.h 308287 
  /branches/1.8/main/loader.c 308287 
  /branches/1.8/pbx/pbx_ael.c 308287 
  /branches/1.8/res/res_agi.c 308287 
  /branches/1.8/res/res_calendar_caldav.c 308287 
  /branches/1.8/res/res_calendar_ews.c 308287 
  /branches/1.8/res/res_calendar_exchange.c 308287 
  /branches/1.8/res/res_calendar_icalendar.c 308287 
  /branches/1.8/res/res_config_curl.c 308287 
  /branches/1.8/res/res_config_odbc.c 308287 
  /branches/1.8/res/res_fax_spandsp.c 308287 

Diff: https://reviewboard.asterisk.org/r/1121/diff


Testing
-------

Compile testing only.  However, the code is identical to the existing nonoptreq code, which is tested and working properly.


Thanks,

Tilghman

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110219/b0f366f5/attachment.htm>


More information about the asterisk-dev mailing list