[asterisk-dev] [Code Review] 0018729: [regression] Dial() and Queue() with a macro argument are broken by AEL macro compilation change

kkm reviewboard at asterisk.org
Tue Feb 8 20:22:32 CST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1097/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

#18480 replaced AEL "macro" entry point from "s" to "~~s~~". Dial() and Queue() still sent their GoSub invocation into the extension "s", and failed. Here I changed the target extension in Dial and Queue to match the "~~s~~".

I am pretty sure these are the only places where the extension is mentioned, but please confirm.


This addresses bug 18729.
    https://issues.asterisk.org/view.php?id=18729


Diffs
-----

  /trunk/apps/app_dial.c 307141 
  /trunk/apps/app_queue.c 307141 

Diff: https://reviewboard.asterisk.org/r/1097/diff


Testing
-------

1.8.3 rc2 with this patch successfully dispatches calls on our live server now (shudders).


Thanks,

kkm

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110209/b4d99e18/attachment.htm>


More information about the asterisk-dev mailing list