[asterisk-dev] [Code Review] Don't allow a REFER with replaces to try to replace the dialog it is a part of

[Terry Wilson]

> On 2011-02-04 04:53:02, Russell Bryant wrote:
> > If you used SIPp to test this, will you add this as a test case in the test suite?

Sort of. I was unable to get the scenario to work with Asterisk in pedantic mode, which I would kind of like to have when doing a test against an arcane "would never happen in real life" kind of test. If you think it is worth the time to add as a test, I could either 1) write one that doesn't use pedantic mode or 2) spend some more time trying to get pedantic to work with the sipp scenario, or 3) try to come up with a similar test using pjsip.


- Terry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1093/#review3164
-----------------------------------------------------------


On 2011-02-03 13:27:31, Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1093/
> -----------------------------------------------------------
> 
> (Updated 2011-02-03 13:27:31)
> 
> 
> Review request for Asterisk Developers, Olle E Johansson and David Vossel.
> 
> 
> Summary
> -------
> 
> Asterisk currently accepts a REFER with a Refer-To with an embedded Replaces header that matches the dialog of the REFER. This would be a situation like A calls B, A calls C, A transfers B to A, which is just silly. This patch makes the transfer fail instead of making Asterisk freak out and forget to hang other channels up.
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/channels/chan_sip.c 306052 
> 
> Diff: https://reviewboard.asterisk.org/r/1093/diff
> 
> 
> Testing
> -------
> 
> Used sipp to test that the transfer failed properly in the aforementioned case. Used polycom phones to ensure that normal transfers still worked.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110207/7f5d3b7d/attachment.htm>