[asterisk-dev] [Code Review] Fix some issues in the provisional response keepalive code.

Russell Bryant reviewboard at asterisk.org
Sat Dec 31 12:50:38 CST 2011

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 31, 2011, 12:50 p.m.)

Review request for Asterisk Developers.


1) Fix a sip_pvt reference leak.  If the scheduler callback returned 0, it did not release the reference to the associated sip_pvt.
2) Add locking in the scheduler callback.  This code runs from the scheduler, which is executed in the SIP monitor thread.  A channel thread will be working with the sip_pvt at the same time.  Use sip_pvt_lock_full to ensure that the ast_channel/sip_pvt locking order is honored.

This addresses bug ASTERISK-18979.

Diffs (updated)

  /branches/1.8/channels/chan_sip.c 349445 

Diff: https://reviewboard.asterisk.org/r/1648/diff


Currently running under heavy load on the reporter's production system.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111231/d4fdf948/attachment.htm>

More information about the asterisk-dev mailing list