[asterisk-dev] [Code Review]: Support 'deaf' participants in ConfBridge

[fabled]

> On Dec. 30, 2011, 8:46 a.m., Matt Jordan wrote:
> > You'll also need to update the CHANGES and confbridge sample configuration file with the new options and sound file overrides.  You may also want to consider adding a DTMF menu option that would allow a "Deafen / Undeafen" option to the conference menu.

OK. Will update CHANGES, and sample config (with both: example menu and startdeaf=yes).


> On Dec. 30, 2011, 8:46 a.m., Matt Jordan wrote:
> > /trunk/apps/app_confbridge.c, lines 2092-2098
> > <https://reviewboard.asterisk.org/r/1645/diff/1/?file=22464#file22464line2092>
> >
> >     I'm not really a fan of methods that have dual purposes.  I'd prefer there to be a generic mute helper, and a generic deafen helper.

The function would be mostly redundant copy/paste then. Would it be worth to create a generic "feature_helper", and pass a callback function to do the feature bit twidling?


> On Dec. 30, 2011, 8:46 a.m., Matt Jordan wrote:
> > /trunk/apps/app_confbridge.c, line 2122
> > <https://reviewboard.asterisk.org/r/1645/diff/1/?file=22464#file22464line2122>
> >
> >     Does adding the test suite event mean that you also plan to write a test for this new feature? :-)

I was hoping your test framework guru could do it :)


> On Dec. 30, 2011, 8:46 a.m., Matt Jordan wrote:
> > /trunk/apps/app_confbridge.c, line 2133
> > <https://reviewboard.asterisk.org/r/1645/diff/1/?file=22464#file22464line2133>
> >
> >     Same here about dual purpose methods.

Would work here too; just add the callback to do feature twiddling, and also the verb as explicit parameters. Would remove redundancy.

Does that sound acceptable?


- fabled


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1645/#review5086
-----------------------------------------------------------


On Dec. 30, 2011, 8:44 a.m., fabled wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1645/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2011, 8:44 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Support 'deaf' participants in ConfBridge
> 
> 
> This addresses bug ASTERISK-19109.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19109
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_confbridge.c 349196 
>   /trunk/apps/confbridge/conf_config_parser.c 349196 
>   /trunk/apps/confbridge/include/confbridge.h 349196 
>   /trunk/bridges/bridge_softmix.c 349196 
>   /trunk/include/asterisk/bridging_features.h 349196 
> 
> Diff: https://reviewboard.asterisk.org/r/1645/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> fabled
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111230/fec1ce29/attachment-0001.htm>