[asterisk-dev] [Code Review]: fix regression after rev 336294 that music on hold didnt worked when a call was put on hold in a local_bridge.

[schmidts]

> On Dec. 22, 2011, 8:50 a.m., jrose wrote:
> > Hey, this looks right to me, but could you describe the call scenario to me a little better?  I want to know things like what types of channels you were using and the settings on them, especially for directmedia in the case of SIP.  The patch you are referencing was made to deal with nasty directmedia issues involving multiple servers, and those haven't been completely resolved yet, so I'm interested in what that could have broken and what this possibly could fix.

i have attached my sip.conf and extension.conf to reproduce this to the linked issue. My call setup is very simple. two sip phones behind a sip proxy and behind nat. both with directmedia=no. I also tried it with two sip phones directly connected to asterisk to make sure its not my proxy.

i also had some problems with directmedia enabled across two asterisk servers but i just disabled directmedia and then the one way audio problems stoped.

Maybe you could take a look at the debug log i have attached to the issue. I can also try to enable directmedia but normally all my phones are behind nat so i dont think this will work well.


- schmidts


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1640/#review5053
-----------------------------------------------------------


On Dec. 22, 2011, 3:58 a.m., schmidts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1640/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2011, 3:58 a.m.)
> 
> 
> Review request for Asterisk Developers and jrose.
> 
> 
> Summary
> -------
> 
> with adding the AST_CONTROL_UPDATE_RTP_PEER control frame music on hold stoped working when a call was put on hold. The problem was that the control frame was only handled when received in a remote_bridge but not in a local_bridge.
> By adding the handling of the UPDATE_RTP_PEER frame also to local_bridge moh works again.
> 
> 
> This addresses bug ASTERISK-19095.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19095
> 
> 
> Diffs
> -----
> 
>   team/schmidts/unleash-the-beast/main/rtp_engine.c 348832 
> 
> Diff: https://reviewboard.asterisk.org/r/1640/diff
> 
> 
> Testing
> -------
> 
> tested several calls. Moh is working again when a call is put on hold.
> 
> 
> Thanks,
> 
> schmidts
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111222/80ea94d0/attachment.htm>