[asterisk-dev] [Code Review] CDR Overhaul - Convert all python CDR tests to use CDRTestCase

Paul Belanger reviewboard at asterisk.org
Wed Dec 21 17:44:27 CST 2011 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1637/#review5048
-----------------------------------------------------------


Nice work on this, some 1.4 compatible issue but looks good aside from that.


/asterisk/trunk/tests/cdr/console_dial_sip_answer/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1637/#comment9310>

    this will not work on 1.4, same => is 1.6.1+



/asterisk/trunk/tests/cdr/console_dial_sip_busy/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1637/#comment9312>

    same as above



/asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1637/#comment9313>

    same



/asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1637/#comment9315>

    again, not 1.4 compatible



/asterisk/trunk/tests/cdr/console_dial_sip_transfer/run-test
<https://reviewboard.asterisk.org/r/1637/#comment9314>

    typo?



/asterisk/trunk/tests/cdr/console_fork_after_busy_forward/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1637/#comment9316>

    more



/asterisk/trunk/tests/cdr/console_fork_before_dial/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1637/#comment9317>

    more


- Paul


On Dec. 21, 2011, 4:14 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1637/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2011, 4:14 p.m.)
> 
> 
> Review request for Asterisk Developers, Paul Belanger and Matt Jordan.
> 
> 
> Summary
> -------
> 
> This rather obnoxiously large patch converts every python (read: not lua) CDR test in the testsuite to use the new CDRTestCase class made by Paul and myself. It significantly reduces the amount of duplicate code within the CDR tests by offloading result checking and common pass/failure conditions to the CDRTestCase class.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/cdr/console_dial_sip_busy/test-config.yaml 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs/ast1/branch-1.4/sip.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_busy/configs/ast2/sip.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_busy/run-test 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_busy/configs/ast2/branch-1.4/sip.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_busy/configs/ast2/extensions.conf 2951 
>   /asterisk/trunk/tests/cdr/cdr_userfield/configs/ast1/extensions.conf 2951 
>   /asterisk/trunk/tests/cdr/cdr_userfield/configs/ast1/manager.conf 2951 
>   /asterisk/trunk/tests/cdr/cdr_userfield/run-test 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_answer/configs/ast1/branch-1.4/sip.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_answer/configs/ast1/extensions.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_answer/configs/ast1/sip.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_answer/configs/ast2/branch-1.4/sip.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_answer/configs/ast2/extensions.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_answer/configs/ast2/sip.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_answer/run-test 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_answer/test-config.yaml 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_busy/configs/ast1/branch-1.4/sip.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_busy/configs/ast1/extensions.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_busy/configs/ast1/manager.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_busy/configs/ast1/sip.conf 2951 
>   /asterisk/trunk/tests/cdr/cdr_unanswered_yes/configs/ast1/extensions.conf 2951 
>   /asterisk/trunk/tests/cdr/cdr_unanswered_yes/configs/ast1/manager.conf 2951 
>   /asterisk/trunk/tests/cdr/cdr_unanswered_yes/run-test 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs/ast1/extensions.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs/ast1/manager.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs/ast1/sip.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs/ast2/branch-1.4/sip.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs/ast2/extensions.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs/ast2/sip.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_congestion/run-test 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_congestion/test-config.yaml 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs/ast1/branch-1.4/sip.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs/ast1/extensions.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs/ast1/manager.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs/ast1/sip.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs/ast2/branch-1.4/sip.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs/ast2/extensions.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs/ast2/sip.conf 2951 
>   /asterisk/trunk/tests/cdr/console_dial_sip_transfer/run-test 2951 
>   /asterisk/trunk/tests/cdr/console_fork_after_busy_forward/configs/ast1/extensions.conf 2951 
>   /asterisk/trunk/tests/cdr/console_fork_after_busy_forward/configs/ast1/manager.conf 2951 
>   /asterisk/trunk/tests/cdr/console_fork_after_busy_forward/configs/ast1/sip.conf 2951 
>   /asterisk/trunk/tests/cdr/console_fork_after_busy_forward/configs/ast2/branch-1.4/sip.conf 2951 
>   /asterisk/trunk/tests/cdr/console_fork_after_busy_forward/configs/ast2/extensions.conf 2951 
>   /asterisk/trunk/tests/cdr/console_fork_after_busy_forward/configs/ast2/sip.conf 2951 
>   /asterisk/trunk/tests/cdr/console_fork_after_busy_forward/run-test 2951 
>   /asterisk/trunk/tests/cdr/console_fork_after_busy_forward/test-config.yaml 2951 
>   /asterisk/trunk/tests/cdr/console_fork_before_dial/configs/ast1/branch-1.4/sip.conf 2951 
>   /asterisk/trunk/tests/cdr/console_fork_before_dial/configs/ast1/extensions.conf 2951 
>   /asterisk/trunk/tests/cdr/console_fork_before_dial/configs/ast1/manager.conf 2951 
>   /asterisk/trunk/tests/cdr/console_fork_before_dial/configs/ast1/sip.conf 2951 
>   /asterisk/trunk/tests/cdr/console_fork_before_dial/configs/ast2/branch-1.4/sip.conf 2951 
>   /asterisk/trunk/tests/cdr/console_fork_before_dial/configs/ast2/extensions.conf 2951 
>   /asterisk/trunk/tests/cdr/console_fork_before_dial/configs/ast2/sip.conf 2951 
>   /asterisk/trunk/tests/cdr/console_fork_before_dial/run-test 2951 
>   /asterisk/trunk/tests/cdr/console_fork_before_dial/test-config.yaml 2951 
>   /asterisk/trunk/tests/cdr/nocdr/configs/ast1/manager.conf 2951 
>   /asterisk/trunk/tests/cdr/nocdr/run-test 2951 
>   /asterisk/trunk/tests/cdr/tests.yaml 2951 
> 
> Diff: https://reviewboard.asterisk.org/r/1637/diff
> 
> 
> Testing
> -------
> 
> All of the CDR tests have been ran to make sure they behave as expected and they have been checked to ensure that they produce the same expected CDR files (for the most part.  Some elements have changed due to necessity so that soundcard dependency could be removed) and that these expectations are validated accordingly.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111221/81f9000b/attachment-0001.htm>

More information about the asterisk-dev mailing list